Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed yml #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed yml #30

wants to merge 2 commits into from

Conversation

mwu56jude
Copy link

the original yml seems to provide wrong version of python and to lack some dependencies and I have fixed it so the user can install via option1 without error message pop out.

Copy link

@austinMLB austinMLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, I think you'd want to keep the name of the yml file or change the README to reflect the new name.

dependencies:
- python>=3.9,<3.10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think changing the python version is strictly necessary with the changes. Mine worked fine with the existing 3.9 restrictions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
This this what I got while trying to install on 3 of the windows systems and that is the main reason I have pin point a specific version was working for us. If you think that is not necessary I can always change it back.
punctatools_error

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants