Exception in the load process of the object structure resolved #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stity
requested changes
Oct 9, 2017
| @@ -242,7 +242,7 @@ angular.module('atlasDemo').provider('loadingManager', ['mainAppProvider', 'volu | |||
|
|
|||
| var objStructures = atlasStructure.Structure.filter(item => { | |||
| if (Array.isArray(item.sourceSelector)) { | |||
| return item.sourceSelector.some(selector => /\.obj$/.test(selector.dataSource.source)); | |||
| return item.sourceSelector.some(selector => /\.obj$/.test(selector.dataSource)); | |||
There was a problem hiding this comment.
Here we want to list structure using ".obj" files so we can load them later using the OBJLoader.
The correction you provide is wrong as dataSource is an object and the regex can not be used on objects.
To account for the presence of the object, the code should be : test(selector.dataSource && selector.dataSource.source)
|
@SolidusAbi I added a comment to your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular expression test generates a exception because it was looking for a dataSource.source field and there were elements in the array do not contain dataSource field.