Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to graphing adapter #2

Open
wants to merge 3 commits into
base: graphing-adapter
Choose a base branch
from

Conversation

Evelyn-Johns
Copy link
Collaborator

Additions:

  • Adapter can tolerate nested structures in config
  • Datasets can be added without using config file, in another adapter/project
  • Min and max parameters have been added to the tree

Improvements/questions:

  • Dictionary/json manipulation functions formatting? (should they be separate class methods?)
  • Could replace "location" parameter in config file with a function that generates it automatically?

@Evelyn-Johns Evelyn-Johns requested a review from ANeaves January 16, 2025 09:24

endpoints = []

def get_last_dict(dictionary):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to define this method within the load_config method?

self.max_list.pop(0)

self.min = min(self.min_list)
self.max = max(self.max_list)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels redundant? why not just keep a single Min and Max value and check each time if the new value is more/less, then update it? If you need it to be the min/max of only whats currently visible, then you can just do what you've done above and do min(data)

…nitialization of parameter tree, add comments
@Evelyn-Johns Evelyn-Johns requested a review from ANeaves January 20, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants