This repository was archived by the owner on May 20, 2020. It is now read-only.
Whitelist files in build.rs #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
reviewed
Aug 4, 2017
build.rs
Outdated
| path: String::from(entry.path().to_str().unwrap()).replace("\\", "/"), | ||
| }); | ||
| let whitelist = vec
There was a problem hiding this comment.
will this include subfolders?
There was a problem hiding this comment.
This particular pattern will not. If we write it as assets/** it will include subfolders. The glob pattern syntax is here.
There was a problem hiding this comment.
Ok, I think that we should include subfolders as well.
|
@hjr3 looks like the tests are failing due to not being able to find files. I think you need to prepend "frontend/" to each of those paths in the whitelist. |
|
I believe this is ready to go. The build is still failing due to upstream issues. Let me know if there is something else I should do. |
|
The build should pass with a rebase. |
build.rs would add every file in frontend/dist to asset.in. This would cause hard to debug errors when files were unintentionally placed in frontend/dist. Fixes steveklabnik#58
|
@euclio indeed it does now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.rs would add every file in frontend/dist to asset.in. This would
cause hard to debug errors when files were unintentionally placed in
frontend/dist.
Fixes #58