wrap hooks object so that plugins can add custom hooks #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this might fix #44
I saw issues with incremental builds especially with
HardSourceWebpackPlugin. This changes fixes it for me.Debugging HardSourceWebpackPlugin, it looks like they are modifying the hooks objects to add more hooks
https://github.com/mzgoddard/hard-source-webpack-plugin/blob/5122a1c3c3660d94798e73e73b6e36d0fc1d784d/lib/SystemArchetype.js#L14
https://github.com/mzgoddard/hard-source-webpack-plugin/blob/master/lib/util/plugin-compat.js#L59
These modified hooks are okay in the first run, but speed-measure-plugin does not modify the actual hooks when these registrations happen. This makes the subsequent newly created hooks object fail during the next incremental build.