Skip to content

Attempt to fix tests build for android #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2025
+6 −6
Merged

Attempt to fix tests build for android #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83c0c98
Attempt to fix tests build for android
NikolayJuly Aug 13, 2025
b7b7923
Disable for Android same tests, which disabled for Linux
NikolayJuly Aug 17, 2025
4f2fdff
Change iOS simulator device to Any iOS Simulator Device
nathanfallet Aug 30, 2025
9c14b66
Trying iPhone 16 with iOS 18.4
nathanfallet Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Build and test
on: [push, pull_request]
env:
IOS_SIMULATOR: "iPhone 16"
IOS_VERSION: "18.0"
IOS_VERSION: "18.4"
jobs:
build:
runs-on: macos-15
Expand Down
2 changes: 1 addition & 1 deletion Tests/SQLiteTests/Core/ConnectionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ class ConnectionTests: SQLiteTestCase {
}

// https://github.com/stephencelis/SQLite.swift/issues/1071
#if !os(Linux)
#if !(os(Linux) || os(Android))
func test_createFunction_withArrayArguments() throws {
db.createFunction("hello") { $0[0].map { "Hello, \($0)!" } }

Expand Down
4 changes: 2 additions & 2 deletions Tests/SQLiteTests/Schema/SchemaDefinitionsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ColumnDefinitionTests: XCTestCase {
defaultValue: .numericLiteral("123.123"), references: nil))
]

#if !os(Linux)
#if !(os(Linux) || os(Android))
override class var defaultTestSuite: XCTestSuite {
let suite = XCTestSuite(forTestCaseClass: ColumnDefinitionTests.self)

Expand Down Expand Up @@ -183,7 +183,7 @@ class IndexDefinitionTests: XCTestCase {
"CREATE INDEX IF NOT EXISTS \"index_tests\" ON \"tests\" (\"test_column\")")
]

#if !os(Linux)
#if !(os(Linux) || os(Android))
override class var defaultTestSuite: XCTestSuite {
let suite = XCTestSuite(forTestCaseClass: IndexDefinitionTests.self)

Expand Down
2 changes: 1 addition & 1 deletion Tests/SQLiteTests/Typed/CustomAggregationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import SQLite3
#endif

// https://github.com/stephencelis/SQLite.swift/issues/1071
#if !os(Linux)
#if !(os(Linux) || os(Android))

class CustomAggregationTests: SQLiteTestCase {
override func setUpWithError() throws {
Expand Down
2 changes: 1 addition & 1 deletion Tests/SQLiteTests/Typed/CustomFunctionsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import XCTest
import SQLite

// https://github.com/stephencelis/SQLite.swift/issues/1071
#if !os(Linux)
#if !(os(Linux) || os(Android))

class CustomFunctionNoArgsTests: SQLiteTestCase {
typealias FunctionNoOptional = () -> SQLite.Expression<String>
Expand Down