update the get_license_key function to be able to get from a file

[kadencewp]

Previously we were only setting this to Local so that the file was not looked at but now we do want to use embed so we need to make this default to either network if in network mode or any so that the file can be checked.

[defunctl]

This going to check the network again even if we don't allow multisite licenses, so you'll have to adjust this to first check for local and if no local is found, check for default if you want this to fall back to a file (assuming $network === false).

[kadencewp]

The main branch checks the network options table if it exists. The difference is that with our branch you can have it only checking the network options and not allowing you to do anything on the local subsite if your in the mode.

[defunctl]

Am I incorrect that if $network = allows_multisite_license( $resource ); returns false, then passing any to $resource->get_license_key() would then possibly find a multisite license key that shouldn't be allowed to be used?

Because that ultimately does a number of complex checks to ultimately arrive at this chart..

If $network === false and yet we still end up pulling a key, isn't that going to try register a multisite key on a single site if the plugin isn't network activated (something Uplink wasn't checking for)?

[defunctl]

What I'm suggesting is the following: We only specifically check network or local and fallback to "file", using default for both (assuming you want that for network?).

/**
 * A multisite license aware way to get a resource's license key automatically
 * from the network or local site level.
 *
 * @param  string  $slug  The plugin/service slug.
 *
 * @throws \RuntimeException
 *
 * @return string
 */
function get_license_key( string $slug ): string {
	$resource = get_resource( $slug );

	if ( ! $resource ) {
		return '';
	}

	$network = allows_multisite_license( $resource );

	if ( $network ) {
		return $resource->get_license_key( 'network' ) ?: $resource->get_license_key( 'default' );
	}

	return $resource->get_license_key( 'local' ) ?: $resource->get_license_key( 'default' );
}

[kadencewp]

it's totally ok for the key to be found on the network options table if it were somehow set there, this is how it works in the main branch. The difference is that if it's network license then it's one activation for the network, if the key is pulled from the network the subsite still has to activate itself as a different seat.
I don't think we need to move away from the main branch on this and your code would be moving us away from that main branch

[defunctl]

Okay

[defunctl]

@kadencewp actually, should even bother checking the network first then?

Should it just be $resource->get_license_key( 'any' ); if you don't care where the license key comes from?

[kadencewp]

@defunctl Yes I want to check the network because if it's in network mode then I do only want to check the network and in Kadence we don't even show any license input area for subsites