Merge pull request #66 from stellarwp/bugfix/upgrader-source-fatal-error

Fix fatal in filter_upgrader_source_selection()
stellarwp · Feb 29, 2024 · 711da4f · 711da4f
2 parents ac61ceb + ec4b097
commit 711da4f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/src/Uplink/Admin/Provider.php b/src/Uplink/Admin/Provider.php
@@ -150,11 +150,11 @@ public function store_admin_notices( $page ): void {
 	 *
 	 * @since 1.0.0
 	 *
-	 * @param bool         $reply      Whether to bail without returning the package.
-	 *                                 Default false.
-	 * @param string       $package    The package file name or URL.
-	 * @param \WP_Upgrader $upgrader   The WP_Upgrader instance.
-	 * @param array        $hook_extra Extra arguments passed to hooked filters.
+	 * @param  bool|\WP_Error  $reply       Whether to bail without returning the package.
+	 *                                      Default false.
+	 * @param  string          $package     The package file name or URL.
+	 * @param  \WP_Upgrader    $upgrader    The WP_Upgrader instance.
+	 * @param  array           $hook_extra  Extra arguments passed to hooked filters.
 	 *
 	 * @return mixed
 	 */

diff --git a/src/Uplink/Admin/Update_Prevention.php b/src/Uplink/Admin/Update_Prevention.php
@@ -50,14 +50,14 @@ public function is_stellar_uplink_resource( string $plugin ): bool {
 	 *
 	 * @since  4.9.12
 	 *
-	 * @param string       $source        File source location.
-	 * @param mixed        $remote_source Remote file source location.
-	 * @param WP_Upgrader  $upgrader      WP_Upgrader instance.
-	 * @param array<mixed> $extras         Extra arguments passed to hooked filters.
+	 * @param string|WP_Error $source        File source location.
+	 * @param mixed           $remote_source Remote file source location.
+	 * @param WP_Upgrader     $upgrader      WP_Upgrader instance.
+	 * @param array<mixed>    $extras         Extra arguments passed to hooked filters.
 	 *
 	 * @return string|WP_Error
 	 */
-	public function filter_upgrader_source_selection( string $source, $remote_source, WP_Upgrader $upgrader, array $extras ) {
+	public function filter_upgrader_source_selection( $source, $remote_source, WP_Upgrader $upgrader, array $extras ) {
 		if ( ! isset( $extras['plugin'] ) ) {
 			return $source;
 		}

diff --git a/tests/muwpunit.suite.yml b/tests/muwpunit.suite.yml
@@ -18,4 +18,4 @@ modules:
             domain: %WP_DOMAIN%
             adminEmail: [email protected]
             title: 'StellarWP Uplink Tests'
-            theme: twentytwenty
+            theme: twentytwentythree
diff --git a/tests/wpunit.suite.dist.yml b/tests/wpunit.suite.dist.yml
@@ -17,7 +17,7 @@ modules:
             domain: %WP_DOMAIN%
             adminEmail: [email protected]
             title: 'StellarWP Uplink Tests'
-            theme: twentytwenty
+            theme: twentytwentythree
             multisite: false
 
 env: