KAD-4108 Fix setting numeric padding/margin on submenu links #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oakesjosh
requested review from
mark-c-woodard,
gilbert-hernandez and
Copilot
There was a problem hiding this comment.
PR Overview
This PR fixes an issue with submenu links by ensuring that numeric padding and margin values stored as strings are converted to integers before being used in the ResponsiveMeasureRangeControl component.
- Convert meta values for padding and margin from strings to integers using arrayStringToInt.
- Update both padding and margin controls in src/blocks/navigation/edit-inner.js.
Reviewed Changes
| File | Description |
|---|---|
| src/blocks/navigation/edit-inner.js | Converts stored string meta values to integers for padding and margin controls |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
🎉 Zip build complete |
gilbert-hernandez
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAD-4108
This issue is due to CPT needing meta to be stored as a string, we convert the numeric padding values to a string. The padding component sees a string and thinks it's a variable value (SM, MD, LG). I created the
arrayStringToInthelper a while back to support converting strings of number back into integers so the component handles them correctly. We use this function in this file and the advanced header.