-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action for slic configuration #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a couple more suggestions and questions
Thanks, @defunctl, it makes sense! I've applied your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of grammar things I missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, you might want to wait for @borkweb to give it a look over as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this addition! Nice work 🥇
The PR adds the reusable action for slic configuration. It will be helpful to run tests in CI. I think two inputs should be enough for most cases (maybe I missed something). Anyway, action can be improved if more feedback is provided.
Regarding the complete workflow, I guess it might be useful as well, but the building step is more complicated. So I decided to add just an example that can be copied and adapted per-project needs. Maybe it could be a reusable workflow in the future (with partially the same steps as
zip.yml
has).