Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for slic configuration #16

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Add action for slic configuration #16

merged 6 commits into from
Feb 20, 2025

Conversation

shvlv
Copy link
Contributor

@shvlv shvlv commented Feb 18, 2025

The PR adds the reusable action for slic configuration. It will be helpful to run tests in CI. I think two inputs should be enough for most cases (maybe I missed something). Anyway, action can be improved if more feedback is provided.

Regarding the complete workflow, I guess it might be useful as well, but the building step is more complicated. So I decided to add just an example that can be copied and adapted per-project needs. Maybe it could be a reusable workflow in the future (with partially the same steps as zip.yml has).

@JasonTheAdams JasonTheAdams removed their request for review February 18, 2025 22:29
@shvlv shvlv requested a review from defunctl February 19, 2025 20:38
Copy link
Contributor

@defunctl defunctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a couple more suggestions and questions

@shvlv
Copy link
Contributor Author

shvlv commented Feb 19, 2025

Thanks, @defunctl, it makes sense! I've applied your suggestions.

@defunctl defunctl self-requested a review February 19, 2025 21:53
Copy link
Contributor

@defunctl defunctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of grammar things I missed

@defunctl defunctl self-requested a review February 19, 2025 22:07
Copy link
Contributor

@defunctl defunctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, you might want to wait for @borkweb to give it a look over as well.

Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this addition! Nice work 🥇

@shvlv shvlv merged commit 88f744b into main Feb 20, 2025
@shvlv shvlv deleted the feat/slic branch February 20, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants