Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove illuminate/collections dependency causing conflicts with later versions #7

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Remove illuminate/collections dependency causing conflicts with later versions #7

merged 4 commits into from
Feb 7, 2025

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Feb 7, 2025 •
edited
Loading

Main Changes

  • Removes the illuminate/collections dependency to avoid conflicts and given we were only using the value function of that package, I just added it as a private static method instead.
  • Update GitHub workflows to their latest versions.

@defunctl defunctl added the bug Something isn't working label Feb 7, 2025
@defunctl defunctl added this to the 1.3.1 milestone Feb 7, 2025
@defunctl defunctl self-assigned this Feb 7, 2025
@defunctl defunctl marked this pull request as ready for review February 7, 2025 18:08
@defunctl defunctl changed the title Remove unneeded illuminate/collections Remove illuminate/collections dependency causing conflicts with later versions Feb 7, 2025
johnhooks
johnhooks approved these changes Feb 7, 2025
View reviewed changes
Copy link

@johnhooks johnhooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@defunctl looks great, carrying around that dependency just for value was unnecessary.

@defunctl defunctl merged commit 315a9b2 into main Feb 7, 2025
2 checks passed
@defunctl defunctl deleted the bugfix/remove-illuminate-collections branch February 7, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnhooks johnhooks johnhooks approved these changes

@tarecord tarecord Awaiting requested review from tarecord

@borkweb borkweb Awaiting requested review from borkweb

Assignees

@defunctl defunctl

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@defunctl @johnhooks