Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soroban test upgrades #4654

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SirTyson
Copy link
Contributor

Description

Resolves #4605

This test makes the following changes:

  1. Refactors the root TestAccount to be managed by App
    • Prior to this change, there we frequently issues with sequence numbers. While there is only one actual root account, tests would periodically create multiple TestAccount objects for the one actual account. TestAccount caches the next sequence number, so this approach cause issues since one TestAccount root object would be out of sync with the others. This change makes it such that there is only one TestAccount object for the root.
  2. modifySorobanNetworkConfig goes through full upgrade process
    • Previously, this function was very hacky and lead to testing bugs since we commited network config entries directly to the BucketList without going through the proper ledgerClose flow. Now, we actually go through the correct upgrade contract upload -> invoke -> arm -> externalize upgrade ledger flow.
    • Note that meta diffs have changed significantly, since each call to modifySorobanNetworkConfig now closes 4 ledgers. The root account also pays for these TXs, so balances have changed slightly as well.
  3. Add support for ledgerMaxDependentTxClusters in upgrade related tests.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@SirTyson SirTyson requested review from sisuresh and dmkozh February 24, 2025 21:34
@SirTyson SirTyson changed the title Fix soroban test upgrades 2 Fix soroban test upgrades Feb 24, 2025
@SirTyson SirTyson force-pushed the fix-soroban-test-upgrades-2 branch from fdbeacc to 5c0152f Compare February 24, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix modifySorobanNetworkConfig
2 participants