new SAT-based, process-isolated quorum intersection checker #4653
Conversation
| mLastQuorumMapIntersectionState, mApp.getProcessManager(), true, | ||
| mApp.getConfig().QUORUM_INTERSECTION_CHECKER_TIME_LIMIT_MS, | ||
| mApp.getConfig().QUORUM_INTERSECTION_CHECKER_MEMORY_LIMIT_BYTES); | ||
| // TODO: parse the metrics and send to medida |
There was a problem hiding this comment.
If you're not going to do this in this PR, can you file it as a followup?
| @@ -1858,21 +1911,21 @@ HerderImpl::checkAndMaybeReanalyzeQuorumMap() | |||
| ZoneScoped; | |||
There was a problem hiding this comment.
this prefix of the v1 and v2 code -- the bit that checks whether it is stable, or already running, etc. -- seems like it's repeated between the two. Do you think it could be factored out easily?
| template <typename T> | ||
| std::vector<uint8_t> | ||
| toVec(T const& t) | ||
| { | ||
| return std::vector<uint8_t>(xdr::xdr_to_opaque(t)); | ||
| } | ||
|
|
||
| template <typename T> | ||
| CxxBuf | ||
| toCxxBuf(T const& t) | ||
| { | ||
| return CxxBuf{std::make_unique<std::vector<uint8_t>>(toVec(t))}; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is duplicated code from InvokeHostFunctionOpFrame.cpp. Please factor out into src/utils/types.h or add a src/rust/RustUtils.h or something?
| namespace stellar | ||
| { | ||
|
|
||
| // static adaptor class over rust QuorumChecker that exposes its functionalities |
There was a problem hiding this comment.
Not a big deal (and you don't need to change if you're happy as-is) but .. generally I think if we have a bunch of essentially static/free functions, we'd just stick them in a sub-namespace rather than a class-full-of-static-methods. Like the class part seems a little odd if nobody ever instantiates it. But I'm not too particular.
Description
Resolves #4106
New quorum intersection checker take 2 (with process-isolation, supersedes #4629).
stellar/stellar-quorum-analyzer, the underneath Rust library that utilizes SAT-solving.USE_QUORUM_INTERSECTION_CHECKER_V2, or if running in command line--v2stellar-core check-quorum-intersectionin a separate processQUORUM_INTERSECTION_CHECKER_TIME_LIMIT_MSandQUORUM_INTERSECTION_CHECKER_MEMORY_LIMIT_BYTESin the config file, or--time-limit-msand `--memory-limit-bytes if running command-line mode).This approach is significantly more performant than the current one, allowing live monitoring of network beyond 7 tier-1 organizations.
A single quorum-intersection check for a 16-org tier 1 quorum configuration sample took roughly 2ms, whereas previously it was unable to solve.
(Here are some sample quorums configs, you can check them by running the following command
$ stellar-core check-quorum-intersection ~/$PATH-TO-RUST-REPO/tests/test_data/random/for_stellar_core/almost_symmetric_network_16_orgs_delete_prob_factor_11_for_stellar_core.json --result-json output.jsonunder your favorite benchmark tool)Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)(Marking draft for stellar/stellar-quorum-analyzer#1 to be merged first)