Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-test sorobans against their observations with core-chosen rust compiler #4652

Merged

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Feb 21, 2025

Description

This just adds an entry to make check to re-run the tests of each soroban module using the toolchain that stellar-core is building soroban with. This will catch early any divergence from observation caused by differences between the rust toolchain soroban tested itself against in CI vs. the one core is being built with. It's a small window of difference, but possible.

Resolves stellar/rs-soroban-env#1518

@graydon graydon enabled auto-merge February 22, 2025 00:00
@graydon graydon added this pull request to the merge queue Feb 22, 2025
@anupsdf
Copy link
Contributor

anupsdf commented Feb 22, 2025

How long does it take to run this new test today? (thinking of the impact when we have a lot of old Sorobans)

Merged via the queue into stellar:master with commit 5752780 Feb 22, 2025
13 checks passed
@graydon graydon deleted the bug-1518-make-check-env-observations branch February 22, 2025 01:05
@graydon
Copy link
Contributor Author

graydon commented Feb 22, 2025

How long does it take to run this new test today? (thinking of the impact when we have a lot of old Sorobans)

Takes about 1 minute per soroban. I'm not worried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New job that tests old-env observations are stable on new rust versions
3 participants