re-test sorobans against their observations with core-chosen rust compiler #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Feb 21, 2025
|
How long does it take to run this new test today? (thinking of the impact when we have a lot of old Sorobans) |
Takes about 1 minute per soroban. I'm not worried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This just adds an entry to
make checkto re-run the tests of each soroban module using the toolchain that stellar-core is building soroban with. This will catch early any divergence from observation caused by differences between the rust toolchain soroban tested itself against in CI vs. the one core is being built with. It's a small window of difference, but possible.Resolves stellar/rs-soroban-env#1518