Changed random eviction cache to accounts only #4650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a configurable memory based cap to the LiveBucketList random eviction cache. It also modifies the cache such that only accounts are stored.
Following initial testing, the random eviction cache improved TX flooding performance, but had virtually no effect on apply time. This makes sense, since apply time already leverages the ltx cache and only makes at most one disk read per ledger entry. TX flooding on the other hand has no such queue and constantly re reads entries off disk. Given that we already have an ltx cache for apply time, it makes sense to only cache the entry types that are used by transaction flooding (i.e.
ACCOUNT
).My initial default setting is to cache 3 GB. Currently accounts take up about 2.5 GB in the BucketList, so this allows us to cache all accounts with some room for growth, and 3 GB seems like a modest increase in RAM requirements for validators.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)