Optimize the parallel tx set building implementation. #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a relatively simple algorithm, but it should be serviceable for traffic with relatively low amount of transitive IO conflicts.
Also add a simple benchmark in case further improvements are necessary. The changes resulted in up to 20x speedup for some scenarios on my laptop - Avoid unnecessary copies of clusters (use shared ptr instead) - Precompute conflicting transactions, which speeds up low-conflict scenarios very significantly (and this is what we expect to see the most) - Some minor optimizations to avoid doing work when possible Also updated a flaky test scenario.
dmkozh
force-pushed
the
parallel_txset_nomination_opt
branch
from
0ba78fb to
46bc3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also add a simple benchmark in case further improvements are necessary. The changes resulted in up to 20x speedup for some scenarios on my laptop
Also updated a flaky test scenario.
This is rebased on #4486
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)