Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error (Visual C++) #4194

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

MonsieurNicolas
Copy link
Contributor

missing capture in a lambda (not sure why this compiles)

@anupsdf
Copy link
Contributor

anupsdf commented Feb 16, 2024

r+ e850caa

@latobarita latobarita merged commit ccd6f55 into stellar:master Feb 16, 2024
15 checks passed
@bboston7
Copy link
Contributor

I went down a bit of a rabbit hole (partially because I wrote this code) and the code is valid, but MSVC doesn't comply with the standard in this case, though it's admittedly a bit of a strange edge case. It makes me wonder, should we have an MSVC build in our CI system to catch these things automatically?

@MonsieurNicolas
Copy link
Contributor Author

I went down a bit of a rabbit hole (partially because I wrote this code) and the code is valid, but MSVC doesn't comply with the standard in this case, though it's admittedly a bit of a strange edge case. It makes me wonder, should we have an MSVC build in our CI system to catch these things automatically?

the standard works in mysterious ways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants