Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulate subcommand to network survey script #4177

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

bboston7
Copy link
Contributor

Description

This change adds a simulate command to the network survey script that takes a network topology in graphml format (such as the one produced by the survey command) and simulates a survey of said network. It is intended as a tool to use during development of the script itself to test the script without running a survey on the network, and should make it easier to address issues such as #2592.

This is an initial version of the simulate command that will evolve as we need to test the script under additional scenarios.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

This change adds a `simulate` command to the network survey script that
takes a network topology in graphml format (such as the one produced by
the `survey` command) and simulates a survey of said network.  It is
intended as a tool to use during development of the script itself to
test the script without running a survey on the network, and should
make it easier to address issues such as stellar#2592.

This is an initial version of the `simulate` command that will evolve as
we need to test the script under additional scenarios.
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marta-lokhova
Copy link
Contributor

r+ dedc969

@latobarita latobarita merged commit 5633088 into stellar:master Feb 13, 2024
15 checks passed
@bboston7 bboston7 deleted the survey-sim branch February 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants