-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soroban metrics improvement #4175
Conversation
70f4bad
to
1b71127
Compare
@MonsieurNicolas thanks for the review, and sorry about the confusion. Most of the confusion comes from "read" == both read and modified, and "write" == only modified, and "entry" == |
r+ fed81d0 |
Description
Resolves all the items in this checklist: https://github.com/stellar/stellar-core-internal/issues/236#issuecomment-1915049419
Most of them are just some naming and types change. There is one structural change:
A new
SorobanLedgerMetrics
was added inLedgerManager
which tracks soroban resource usage per ledger across all soroban ops (invoke_host_fn, restore_footprint, extend_ttl), and publishes them to new metrics "soroban.ledger.xxx".Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)