Refactor for threadsafe BucketListDB #4172
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step towards #4127
This PR refactors BucketListDB code as a first step towards parallel BucketListDB access. This should have no observable changes.
Currently, BucketListDB is thread safe with the exception of
Bucket
file streams. This change refactors all BucketListDB code out ofBucketList
andBucket
and intoSearchableBucketListSnapshot
andSearchableBucketSnapshot
.SearchableBucketListSnapshot
is a lightweight wrapper aroundBucketList
that storesSearchableBucketSnapshot
.SearchableBucketSnapshot
is another wrapper class that maintains a pointer to the underlyingBucket
as well as a stream to read from the Bucket. In order to facilitate multi thread reads, all BucketList loads must go through these snapshot classes that maintain their own local stream object.In addition to the refactor, a few mutexes have been added around adding entries to the BucketList and modifying ledger header pointers. While these locks are not currently necessary, further work will build on this and actually enable parallel access.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)