Subtract refund from feeCharged #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fails with txINSUFFICIENT_FEE in the tx queue
anupsdf
reviewed
Jan 30, 2024
| @@ -813,6 +813,8 @@ TransactionFrame::refundSorobanFee(AbstractLedgerTxn& ltxOuter) | |||
| return; | |||
| } | |||
|
|
|||
| getResult().feeCharged -= feeRefund; | |||
There was a problem hiding this comment.
No chance of feeCharged going negative here, right?
There was a problem hiding this comment.
There should be no way for this to happen because we always initialize feeCharged to the charged fee. If it were to go negative due to a bug (feeCharged is a int64), it wouldn't be catastrophic from a core perspective because we don't use the value, but would definitely need to be fixed.
The second commit modifies an existing test to make sure that |
marta-lokhova
approved these changes
Jan 30, 2024
|
r+ 2048569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4161
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)