chore: update for Preview 20 #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
chore/v20
branch
2 times, most recently
from
89c691d to
6b4cea5
Compare
- Pin soroban-cli to latest version, 20.1.1 - Update the contract's SDK version - **Copy in `abundance` source from `token` contract** at stellar/soroban-examples#277. Note that I **did not author most of the changes in the `contracts/abundance` folder**. I _only_ copied in the changes originally authored in the `soroban-examples` repo, then updated for the single tweak that this `abundance` contract already had: 1. comments on the `mint` method; 2. slightly modified `mint` behavior. - New CLI's typescript-bindings-generated libraries now return an `AssembledTransaction`, which has a `result` getter and a `signAndSend` method, as explained in stellar/stellar-cli#1034 - Use `stellar-sdk` rather than `soroban-client` - Use latest `@stellar/freighter-api`
Shaptic
approved these changes
Jan 5, 2024
Contributor
Shaptic
left a comment
Shaptic
left a comment
There was a problem hiding this comment.
LGTM! One small dep nitpick
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "soroban-client": "1.0.0-beta.2" | ||
| "stellar-sdk": "^11.1.0" |
Contributor
There was a problem hiding this comment.
Can you use @stellar/stellar-sdk, instead? 🙏
| const paging: Record<PagingKey, { lastLedgerStart?: number, pagingToken?: string }> = {} | ||
|
|
||
| // `EventResponse` is not exported from stellar-sdk | ||
| type EventResponse = SorobanRpc.Api.GetEventsResponse['events'][number] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abundancesource fromtokencontract at Changes for the next release soroban-examples#277. Note that I did not author most of the changes in thecontracts/abundancefolder. I only copied in the changes originally authored in thesoroban-examplesrepo, then updated for the single tweak that thisabundancecontract already had: 1. comments on themintmethod; 2. slightly modifiedmintbehavior.AssembledTransaction, which has aresultgetter and asignAndSendmethod, as explained in feat(bindings-ts)!: API change: returnAssembledTransactions, require signAndSend, and support multi-auth workflows stellar-cli#1034stellar-sdkrather thansoroban-client@stellar/freighter-api