Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize processors #5594

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Reorganize processors #5594

merged 4 commits into from
Feb 10, 2025

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Feb 7, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Reorganizing the processors directory.

There are a lot of in file improvements and organization that need refactoring of functions but the primary goal of this PR is to move from the original flat processors/ structure to processors/<entity>_processor/

Why

Unblock future development

Known limitations

  • There are a lot of poor practices that already existed in these processors. This PR is not going to fix those bad practices now

@chowbao
Copy link
Contributor Author

chowbao commented Feb 7, 2025

@urvisavla to click merge buttons when #5587 is done

@chowbao chowbao enabled auto-merge (squash) February 10, 2025 21:37
@chowbao chowbao merged commit 082069d into stellar:master Feb 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants