This repository was archived by the owner on Apr 23, 2024. It is now read-only.
sdk/state: add validation that the channel has ingested/verified a formationTx before proposing/confirming payments or closes #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acharb
commented
Sep 1, 2021
| @@ -93,7 +93,7 @@ func (c *Channel) ProposeClose() (CloseAgreement, error) { | |||
| } | |||
|
|
|||
| // If the channel is not open yet, error. | |||
| if c.latestAuthorizedCloseAgreement.isEmpty() { | |||
| if c.latestAuthorizedCloseAgreement.isEmpty() || !c.openExecutedAndValidated { | |||
There was a problem hiding this comment.
grouped these checks together, I think if either fail we'd want to throw the same error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
adds a validation to check that the
channel.openExecutedAndValidatedis true before proposing/confirming a payment or closeWHY
if the flag is true then the channel ingested the formation transaction and the channel is officially open. If it's false then the channel should not be able to make or confirm new payments or closes.
closes #235