Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stella: revert Convert stringstream::view() to stringstream::str() for ventura builds #1064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenrui333
Copy link

seeing some ventura build issue as

  In file included from /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/debugger/gui/TrakBallWidget.cxx:18:
  In file included from ../../debugger/gui/TrakBallWidget.hxx:23:
  In file included from ../../debugger/gui/PointingDeviceWidget.hxx:24:
  In file included from ../../debugger/gui/ControllerWidget.hxx:26:
  In file included from /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/emucore/OSystem.hxx:60:
  In file included from ../../emucore/Settings.hxx:23:
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:52:65: error: no member named 'view' in 'std::ostringstream'
      Variant(Int32 i)  { buf().str(""); buf() << i; data = buf().view(); }
                                                            ~~~~~ ^
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:53:65: error: no member named 'view' in 'std::ostringstream'
      Variant(uInt32 i) { buf().str(""); buf() << i; data = buf().view(); }
                                                            ~~~~~ ^
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:54:65: error: no member named 'view' in 'std::ostringstream'
      Variant(float f)  { buf().str(""); buf() << f; data = buf().view(); }
                                                            ~~~~~ ^
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:55:65: error: no member named 'view' in 'std::ostringstream'
      Variant(double d) { buf().str(""); buf() << d; data = buf().view(); }
                                                            ~~~~~ ^
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:56:65: error: no member named 'view' in 'std::ostringstream'
      Variant(bool b)   { buf().str(""); buf() << b; data = buf().view(); }
                                                            ~~~~~ ^
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:57:78: error: no member named 'view' in 'std::ostringstream'
      Variant(const Common::Size& s) { buf().str(""); buf() << s; data = buf().view(); }
                                                                         ~~~~~ ^
  /tmp/stella-20250123-5141-ydz7mo/stella-7.0c/src/common/Variant.hxx:58:79: error: no member named 'view' in 'std::ostringstream'
      Variant(const Common::Point& s) { buf().str(""); buf() << s; data = buf().view(); }
                                                                          ~~~~~ ^

This reverts commit a8a23f6.

relates to Homebrew/homebrew-core#205268

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…licable."

This reverts commit a8a23f6.
@chenrui333 chenrui333 changed the title Revert "Convert stringstream::str() to stringstream::view() where applicable." stella: revert Convert stringstream::view() to stringstream::str() for ventura builds Jan 23, 2025
@chenrui333
Copy link
Author

cc @sa666666

@sa666666
Copy link
Member

This support is available in compliant C++20 compilers, which is now the minimum requirement of Stella.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants