Skip to content

Commit

Permalink
changed VS setting for PGO
Browse files Browse the repository at this point in the history
  • Loading branch information
@thrust26
thrust26 committed Dec 30, 2024
1 parent 6d6522a commit 3932b85
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/os/windows/Stella.vcxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,14 @@
<CharacterSet>MultiByte</CharacterSet>
<PlatformToolset>v143</PlatformToolset>
<EnableASAN>false</EnableASAN>
<WholeProgramOptimization>PGUpdate</WholeProgramOptimization>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release PGO|x64'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
<CharacterSet>MultiByte</CharacterSet>
<PlatformToolset>v143</PlatformToolset>
<EnableASAN>false</EnableASAN>
<WholeProgramOptimization>PGOptimize</WholeProgramOptimization>
<WholeProgramOptimization>true</WholeProgramOptimization>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release-Sanitize|x64'" Label="Configuration">
<ConfigurationType>Application</ConfigurationType>
Expand Down Expand Up @@ -255,7 +256,7 @@
<PrecompiledHeader>
</PrecompiledHeader>
<WarningLevel>Level4</WarningLevel>
<DebugInformationFormat>None</DebugInformationFormat>
<DebugInformationFormat>EditAndContinue</DebugInformationFormat>
<ObjectFileName>$(IntDir)obj\\windows\%(RelativeDir)</ObjectFileName>
<LanguageStandard>stdcpp20</LanguageStandard>
<MultiProcessorCompilation>true</MultiProcessorCompilation>
Expand All @@ -279,6 +280,7 @@
</DataExecutionPrevention>
<TargetMachine>MachineX64</TargetMachine>
<LinkTimeCodeGeneration>UseFastLinkTimeCodeGeneration</LinkTimeCodeGeneration>
<LinkStatus>true</LinkStatus>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release PGO|x64'">
Expand Down Expand Up @@ -319,7 +321,8 @@
<DataExecutionPrevention>
</DataExecutionPrevention>
<TargetMachine>MachineX64</TargetMachine>
<LinkTimeCodeGeneration>PGOptimization</LinkTimeCodeGeneration>
<LinkTimeCodeGeneration>UseFastLinkTimeCodeGeneration</LinkTimeCodeGeneration>
<AdditionalOptions>/USEPROFILE %(AdditionalOptions)</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release-Sanitize|x64'">
Expand Down

4 comments on commit 3932b85

@sa666666
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thrust26, this breaks normal builds with the following error message:

1>cl : command line error D8016: '/ZI' and '/GL' command-line options are incompatible

@sa666666
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it needs to be enabled only for the 'Release PGO' target.

@thrust26
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Can you check why there are no mails send if a build fails?

@sa666666
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the automatic builds use debug mode, and it worked for that target. So I only noticed it when I tried to use 'Release' on my local system.

Please sign in to comment.