Skip to content

CI: pin lint tools and format baseline#292

Merged
ratulsarna merged 10 commits intomainfrom
ci/pin-lint-tools-and-format-baseline
Feb 2, 2026
Merged

CI: pin lint tools and format baseline#292
ratulsarna merged 10 commits intomainfrom
ci/pin-lint-tools-and-format-baseline

Conversation

@ratulsarna
Copy link
Collaborator

This fixes the current CI failure where swiftformat Sources Tests --lint fails due to unpinned Homebrew tool drift.

What changed

  • Pin lint tools in CI (SwiftFormat 0.59.1, SwiftLint 0.63.2) via Scripts/install_lint_tools.sh.
  • Use a single entrypoint Scripts/lint.sh for lint / format.
  • Route pnpm check through the pinned lint script.
  • Apply the SwiftFormat baseline across Sources/ and Tests/.

Review notes

  • Commit 1 is the functional CI/tooling change.
  • Commit 2 is mechanical formatting only.

Commands run

  • ./Scripts/lint.sh format
  • ./Scripts/lint.sh lint
  • swift test --parallel
  • pnpm check
  • ./Scripts/compile_and_run.sh --test

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1466284b99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ratulsarna
Copy link
Collaborator Author

Yep — fixed.

tmp_zip no longer appends .zip onto mktemp output, so we don’t leave behind the extra unused temp file.

@ratulsarna
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ratulsarna ratulsarna merged commit bb5f8d9 into main Feb 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant