Sometimes I need to test some underlying code which closes the standa… #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd output stream, which leads to wrong behaviour of the JUnit tests. They are shown as not run. Also in case of multiple invocation of underlying code which closes the output stream the JVM System.out is not available after the first execution. This patch will allow to prevent close original output stream by givin this control to test righter
|
Thank you for the pull request. I need a few days for reviewing it. How urgent is it for you to have this feature in System Rules? |
|
@stefanbirkner I have local build for my project, no urgency. |
stefanbirkner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rd output stream, which leads to wrong behaviour of the JUnit tests. They are shown as not run.
Also in case of multiple invocation of underlying code which closes the output stream the JVM System.out is not available after the first execution.
This patch will allow to prevent close original output stream by givin this control to test righter