-
Notifications
You must be signed in to change notification settings - Fork 2
Draft: Prepare v1.0.0-rc1 #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 98.90% 98.89% -0.01%
==========================================
Files 15 15
Lines 1457 1452 -5
Branches 155 154 -1
==========================================
- Hits 1441 1436 -5
Misses 9 9
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
After testing: #90 needs to be fixed |
…g ones (Log Volumes)
…ill-state-not-updating Remove LogCollector Fill Level panels from dashboard
…er-guide Add developer guide section to readthedocs for better structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments look good & code changes as well.
Only 1 thing: in the readme we say to start the docker compose we need to run
HOST_IP=127.0.0.1 docker-compose...
Thiscan be misleading as normally we should be using our correct internal IP 192.168.x.x if I am not mistaken ? Also in the config.yaml we should reflect this by using the Kafka external ports as default not the internal ones. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.. autoclass:: Inspector | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will show all methods. I think we should keep these details out of the overview.
.. autoclass:: Detector | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. Too detailed information for the overview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some outdated descriptions, specifically for the Inspection stage in pipeline.rst
. We should update them according to our latest documentation format.
Sure, we should update that according to the actual functionality. @stefanDeveloper, can you clarify if these changes are correct? |
Prepare and document the current state of this project for a RC1 to run in production.