Skip to content

Conversation

stefanDeveloper
Copy link
Owner

Prepare and document the current state of this project for a RC1 to run in production.

Copy link

github-actions bot commented Sep 26, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1452 1443 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/clickhouse_kafka_sender.py 100% 🟢
src/base/kafka_handler.py 100% 🟢
src/base/log_config.py 100% 🟢
src/base/logline_handler.py 100% 🟢
src/base/utils.py 100% 🟢
src/detector/detector.py 99% 🟢
src/inspector/inspector.py 98% 🟢
src/logcollector/batch_handler.py 100% 🟢
src/logcollector/collector.py 100% 🟢
src/logserver/server.py 100% 🟢
src/monitoring/clickhouse_batch_sender.py 99% 🟢
src/monitoring/monitoring_agent.py 96% 🟢
src/prefilter/prefilter.py 100% 🟢
TOTAL 99% 🟢

updated for commit: f486aad by action🐍

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (f6462cb) to head (f486aad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   98.90%   98.89%   -0.01%     
==========================================
  Files          15       15              
  Lines        1457     1452       -5     
  Branches      155      154       -1     
==========================================
- Hits         1441     1436       -5     
  Misses          9        9              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was linked to issues Sep 26, 2025
@stefanDeveloper stefanDeveloper linked an issue Sep 26, 2025 that may be closed by this pull request
@stefanDeveloper
Copy link
Owner Author

After testing: #90 needs to be fixed

@stefanDeveloper stefanDeveloper linked an issue Oct 1, 2025 that may be closed by this pull request
@lamr02n lamr02n mentioned this pull request Oct 13, 2025
Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@maldwg maldwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments look good & code changes as well.
Only 1 thing: in the readme we say to start the docker compose we need to run
HOST_IP=127.0.0.1 docker-compose...
Thiscan be misleading as normally we should be using our correct internal IP 192.168.x.x if I am not mistaken ? Also in the config.yaml we should reflect this by using the Kafka external ports as default not the internal ones. What do you think?

Copy link
Owner Author

@stefanDeveloper stefanDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.. autoclass:: Inspector
:members:
:undoc-members:
:show-inheritance:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show all methods. I think we should keep these details out of the overview.

.. autoclass:: Detector
:members:
:undoc-members:
:show-inheritance:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Too detailed information for the overview.

Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some outdated descriptions, specifically for the Inspection stage in pipeline.rst. We should update them according to our latest documentation format.

@lamr02n
Copy link
Collaborator

lamr02n commented Oct 14, 2025

Comments look good & code changes as well. Only 1 thing: in the readme we say to start the docker compose we need to run HOST_IP=127.0.0.1 docker-compose... Thiscan be misleading as normally we should be using our correct internal IP 192.168.x.x if I am not mistaken ? Also in the config.yaml we should reflect this by using the Kafka external ports as default not the internal ones. What do you think?

Sure, we should update that according to the actual functionality. @stefanDeveloper, can you clarify if these changes are correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation Log Volume Collector Fill State not updating Update docstrings Add Ansible roles

4 participants