Skip to content

chore: fix JavaScript lint errors (issue #6616) #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

GURUPRASADSHARMA
Copy link
Contributor

@GURUPRASADSHARMA GURUPRASADSHARMA commented Apr 9, 2025

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: GURU PRASAD SHARMA <[email protected]>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Apr 9, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 9, 2025

Coverage Report

Package Statements Branches Functions Lines
number/float32/base/to-word 153 / 153
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
153 / 153
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

1 similar comment
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Signed-off-by: Athan <[email protected]>
@kgryte
Copy link
Member

kgryte commented Apr 10, 2025

@GURUPRASADSHARMA Would you mind checking the box in your OP indicating that you've read and acknowledged our contributing guidelines? Thanks!

Without you checking that box, we cannot merge your PR.

@Planeshifter Planeshifter changed the title chore: Fix JavaScript lint errors #6616 chore: fix JavaScript lint errors #6616 Apr 14, 2025
@Planeshifter Planeshifter changed the title chore: fix JavaScript lint errors #6616 chore: fix JavaScript lint errors (issue #6616) Apr 14, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 14, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 14, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: fix JavaScript lint errors (issue #6616)

PR-URL: https://github.com/stdlib-js/stdlib/pull/6626
Ref: https://github.com/stdlib-js/stdlib/issues/6616

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: GURU PRASAD SHARMA <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: GURU PRASAD SHARMA <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 57953ed into stdlib-js:develop Apr 14, 2025
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants