-
-
Notifications
You must be signed in to change notification settings - Fork 806
solved issue #6603 #6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
solved issue #6603 #6609
Conversation
solving linnting problems Signed-off-by: GURU PRASAD SHARMA <[email protected]>
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
@GURUPRASADSHARMA 1) You didn't actually solve the issue. You just changed our lint setting. That is not desired. We have it configured for a reason. 2) Please ignore warnings. Only fix actual lint errors. #6603 specifies a lint error. You should focus on that. |
solving linnting problems
Resolves #6603.
Description
This pull request:
Related Issues
no related issue
This pull request:
@stdlib-js/reviewers