Skip to content

chore: fix JavaScript lint errors (issue #6417 ) - #6424

Merged
kgryte merged 8 commits into
stdlib-js:developfrom
t-sibiraj:fix-#6417-es-lint-errors
Dec 27, 2025
Merged

chore: fix JavaScript lint errors (issue #6417 )#6424
kgryte merged 8 commits into
stdlib-js:developfrom
t-sibiraj:fix-#6417-es-lint-errors

Conversation

@t-sibiraj

@t-sibiraj t-sibiraj commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

Resolves #6417

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a linting error in lib/node_modules/@stdlib/utils/async/if-then/lib/main.js by replacing the usage of new Array() with an array literal ([]) and .push().

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

anandkaranubc and others added 2 commits March 26, 2025 18:39
@anandkaranubc @t-sibiraj
style(changelog): replace space with tabs to fix indentation
ddd2956 
Fix EditorConfig lint error by fixing identation Fixes: stdlib-js#6354

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: passed
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@t-sibiraj
fix(async/if-then): replace new Array() with array literal to satisfy…
1b49a36 
… lint rule

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 28, 2025
@VeerRaj-007 VeerRaj-007 mentioned this pull request Mar 30, 2025
Closed
1 task
@kgryte

kgryte commented Mar 31, 2025

Copy link
Copy Markdown
Member

This PR contains various unrelated changes.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 31, 2025
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Apr 19, 2025
@stdlib-bot stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Jun 12, 2025
@kgryte
style: revert change
38bf5f6 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
chore: revert changes
698b74b 
Signed-off-by: Athan <kgryte@gmail.com>
@stdlib-bot

stdlib-bot commented Dec 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/async/if-then $\color{green}200/200$
$\color{green}+0.00%$ 		$\color{green}21/21$
$\color{green}+0.00%$ 		$\color{green}3/3$
$\color{green}+0.00%$ 		$\color{green}200/200$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
chore: revert changes
849c238 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
chore: fix typo
148a5ca 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 27, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/utils/async/if-then/lib/main.js Outdated
@kgryte
style: add spaces
79ed0a3 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 27, 2025
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 27, 2025
@kgryte

kgryte commented Dec 27, 2025

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 27, 2025
@kgryte
kgryte merged commit e8707d4 into stdlib-js:develop Dec 27, 2025
12 checks passed
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

4 participants

@t-sibiraj @kgryte @stdlib-bot @anandkaranubc