chore: follow-up fixes for commits merged to develop (2026-08-06/07 review window) - #14014
Draft
Planeshifter wants to merge 4 commits into
Draft
chore: follow-up fixes for commits merged to develop (2026-08-06/07 review window)#14014Planeshifter wants to merge 4 commits into
Planeshifter wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-06 08:33 (-0700) (37d7d9e) and 2026-08-07 04:52 (-0700) (9e08b03).This pull request:
stats/base/dists/arcsine/cdf: Fix typo 'retruns' -> 'returns' in the assertion messages left by 7b64d86's ULP-based test migration forstats/base/dists/arcsine/cdf; corrected intest/test.main.js:138andtest/test.native.js:109.tools/make/lib/tools-test-cov: docstring intools/make/lib/tools-test-cov/javascript.mk(introduced fbe844b) documented aFAST_FAILparameter, but the actual variable — used byc8.mkfrom the same commit and consistently elsewhere in the repo — isFAIL_FAST; corrected the name on line 42.blas/ext/base/ztril: Fixblas/ext/base/ztril/test/test.js:26—require( './../lib/' )had a stray trailing slash, out of step with every other package test (see siblingztriu); dropped it to match convention. Originated in 41d170f.assert/has-promise-support: Indocs/repl.txt, commit 258e932 (assert/has-promise-support) left a stray trailing blank line after See Also, inconsistent withhas-async-await-support,has-generator-support, andhas-symbol-support; trimmed to match.Related Issues
No.
Questions
No.
Other
Validation. All 39 commits merged to
developin the 24-hour window were reviewed for typos, bugs, and stdlib style-guide violations. Checks performed: style-guide compliance of new packages (blas/ext/base/ztril,blas/ext/base/gtriu2tril,blas/ext/base/ndarray/{d,g,s}copy-within,stats/base/ndarray/dmeanliC add-on,assert/has-promise-support) against established sibling packages; a bug scan of the full union diff (C kernel loop bounds, napi argument marshalling, complex stride handling, memory allocation/free paths, ULP tolerance migrations, CI workflow guard logic). No runtime bugs were found; the migrated ULP-based test suites all pass.Deliberately excluded (anything requiring interpretation): missing namespace TypeScript declarations / README TOC entries for the newly added packages (
ztril,gtriu2tril,dcopyWithin/gcopyWithin/scopyWithin,hasPromiseSupport) — these land in separate follow-up commits per established repo practice (cf. 6545980 in this same window); and any subjective or judgment-call findings.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated review of commits recently merged to
develop. Claude reviewed the diffs, validated each finding against sibling packages and style guides, and applied the fixes; a human maintainer will audit before promoting from draft.Generated by Claude Code