Skip to content

chore: follow-up fixes for commits merged to develop (2026-08-06/07 review window) - #14014

Draft
Planeshifter wants to merge 4 commits into
developfrom
philipp/fix-commit-review-2026-08-07
Draft

chore: follow-up fixes for commits merged to develop (2026-08-06/07 review window)#14014
Planeshifter wants to merge 4 commits into
developfrom
philipp/fix-commit-review-2026-08-07

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-06 08:33 (-0700) (37d7d9e) and 2026-08-07 04:52 (-0700) (9e08b03).

This pull request:

  • stats/base/dists/arcsine/cdf: Fix typo 'retruns' -> 'returns' in the assertion messages left by 7b64d86's ULP-based test migration for stats/base/dists/arcsine/cdf; corrected in test/test.main.js:138 and test/test.native.js:109.
  • tools/make/lib/tools-test-cov: docstring in tools/make/lib/tools-test-cov/javascript.mk (introduced fbe844b) documented a FAST_FAIL parameter, but the actual variable — used by c8.mk from the same commit and consistently elsewhere in the repo — is FAIL_FAST; corrected the name on line 42.
  • blas/ext/base/ztril: Fix blas/ext/base/ztril/test/test.js:26require( './../lib/' ) had a stray trailing slash, out of step with every other package test (see sibling ztriu); dropped it to match convention. Originated in 41d170f.
  • assert/has-promise-support: In docs/repl.txt, commit 258e932 (assert/has-promise-support) left a stray trailing blank line after See Also, inconsistent with has-async-await-support, has-generator-support, and has-symbol-support; trimmed to match.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 39 commits merged to develop in the 24-hour window were reviewed for typos, bugs, and stdlib style-guide violations. Checks performed: style-guide compliance of new packages (blas/ext/base/ztril, blas/ext/base/gtriu2tril, blas/ext/base/ndarray/{d,g,s}copy-within, stats/base/ndarray/dmeanli C add-on, assert/has-promise-support) against established sibling packages; a bug scan of the full union diff (C kernel loop bounds, napi argument marshalling, complex stride handling, memory allocation/free paths, ULP tolerance migrations, CI workflow guard logic). No runtime bugs were found; the migrated ULP-based test suites all pass.

Deliberately excluded (anything requiring interpretation): missing namespace TypeScript declarations / README TOC entries for the newly added packages (ztril, gtriu2tril, dcopyWithin/gcopyWithin/scopyWithin, hasPromiseSupport) — these land in separate follow-up commits per established repo practice (cf. 6545980 in this same window); and any subjective or judgment-call findings.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated review of commits recently merged to develop. Claude reviewed the diffs, validated each finding against sibling packages and style guides, and applied the fixes; a human maintainer will audit before promoting from draft.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants