chore: fix JavaScript lint errors (issue ##10112)#10119
chore: fix JavaScript lint errors (issue ##10112)#10119Abmarne wants to merge 1 commit intostdlib-js:developfrom
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Yes, all lint errors should be fixed.
I have verified the following:
Fixed the reported error: I replaced the usage of path.dirname with @stdlib/utils/dirname in
lib/node_modules/@stdlib/_tools/docs/www/readme-fragment-file-tree/lib/write.js
, which was the only error reported in the log ("1 problem (1 error, 0 warnings)").
Verified no other occurrences: I scanned the entire lib/node_modules directory for any other usages of path.dirname and found none.
Code Style: I ensured the new code follows the project's style conventions (e.g., spacing around arguments).