Skip to content

chore: fix JavaScript lint errors (issue ##10112)#10119

Open
Abmarne wants to merge 1 commit intostdlib-js:developfrom
Abmarne:fix/lint-error-dirname
Open

chore: fix JavaScript lint errors (issue ##10112)#10119
Abmarne wants to merge 1 commit intostdlib-js:developfrom
Abmarne:fix/lint-error-dirname

Conversation

@Abmarne
Copy link

@Abmarne Abmarne commented Feb 6, 2026

Yes, all lint errors should be fixed.

I have verified the following:

Fixed the reported error: I replaced the usage of path.dirname with @stdlib/utils/dirname in
lib/node_modules/@stdlib/_tools/docs/www/readme-fragment-file-tree/lib/write.js
, which was the only error reported in the log ("1 problem (1 error, 0 warnings)").
Verified no other occurrences: I scanned the entire lib/node_modules directory for any other usages of path.dirname and found none.
Code Style: I ensured the new code follows the project's style conventions (e.g., spacing around arguments).

@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label Feb 6, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants