-
Notifications
You must be signed in to change notification settings - Fork 266
chore: add sds dependency without changes in Go logic (cont) #7157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ivansete-status
wants to merge
11
commits into
develop
Choose a base branch
from
feat/sds-integration-v3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (30)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7157 +/- ##
===========================================
+ Coverage 59.82% 59.83% +0.01%
===========================================
Files 811 811
Lines 113220 113220
===========================================
+ Hits 67730 67750 +20
+ Misses 38605 38593 -12
+ Partials 6885 6877 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jakubgs
approved these changes
Nov 28, 2025
Co-authored-by: Jakub <[email protected]>
5cf32d5 to
13ee56a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #7115, which was reverted because we didn't validate it works nice on status-desktop.
In this PR, we will emphasize status-desktop convenience.