-
Notifications
You must be signed in to change notification settings - Fork 266
refactor: complete nwaku integration (timesource) #7148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Jenkins BuildsClick to see older builds (6)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7148 +/- ##
===========================================
- Coverage 59.96% 59.80% -0.16%
===========================================
Files 809 809
Lines 113228 113228
===========================================
- Hits 67892 67713 -179
- Misses 38490 38627 +137
- Partials 6846 6888 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please point to the changes in waku-go-bindings?
I see that you're moving NTP timesource there. But what effectively change in status-go? We just use an interface defined in a different place? Why is waku/timesource/ntp.go is needed in waku-go-bindings then?
igor-sirotin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm overthinking this though. Not blocking.
|
@igor-sirotin - the change was simply move code from go-waku to waku-go-bindings |
Yes, but from all the code you have moved, you only use the |
Complete some leftovers in nwaku integration.
There will be more PRs similar to that one where we move code from go-waku to waku-go-bindings.
These PR series are inspired by a dependency highlighted by @osmaczko
Changes
Issue