Skip to content

Conversation

@Ivansete-status
Copy link
Contributor

@Ivansete-status Ivansete-status commented Nov 25, 2025

Complete some leftovers in nwaku integration.
There will be more PRs similar to that one where we move code from go-waku to waku-go-bindings.
These PR series are inspired by a dependency highlighted by @osmaczko

Changes

  • Use timesource from waku-go-bindings

Issue

@Ivansete-status Ivansete-status self-assigned this Nov 25, 2025
@Ivansete-status Ivansete-status marked this pull request as draft November 25, 2025 21:36
@Ivansete-status Ivansete-status changed the title Complete nwaku integration refactor: complete nwaku integration Nov 25, 2025
@status-im status-im deleted a comment from github-actions bot Nov 25, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Nov 25, 2025

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bb096c2 #1 2025-11-25 21:40:41 ~4 min linux/status-go 📦zip
✔️ bb096c2 #1 2025-11-25 21:41:04 ~4 min macos/status-go 📦zip
✔️ bb096c2 #1 2025-11-25 21:43:39 ~6 min windows/status-go 📦zip
✔️ bb096c2 #1 2025-11-25 21:44:31 ~7 min linux/nwaku 📦zip
✔️ bb096c2 #1 2025-11-25 21:52:45 ~15 min tests-rpc 📄log
✔️ bb096c2 #1 2025-11-25 22:03:48 ~27 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9e21434 #2 2025-11-25 22:51:09 ~3 min linux/status-go 📦zip
✔️ 9e21434 #2 2025-11-25 22:51:28 ~4 min macos/status-go 📦zip
✔️ 9e21434 #2 2025-11-25 22:54:39 ~7 min windows/status-go 📦zip
✔️ 9e21434 #2 2025-11-25 22:55:16 ~8 min linux/nwaku 📦zip
✔️ 9e21434 #2 2025-11-25 23:03:04 ~15 min tests-rpc 📄log
✔️ 9e21434 #2 2025-11-25 23:14:21 ~27 min tests 📄log
✔️ 290ddf0 #3 2025-11-26 08:48:38 ~4 min linux/status-go 📦zip
✔️ 290ddf0 #3 2025-11-26 08:49:04 ~4 min macos/status-go 📦zip
✔️ 290ddf0 #3 2025-11-26 08:51:11 ~6 min windows/status-go 📦zip
✔️ 290ddf0 #3 2025-11-26 08:52:37 ~7 min linux/nwaku 📦zip
✔️ 290ddf0 #3 2025-11-26 09:01:03 ~16 min tests-rpc 📄log
✔️ 290ddf0 #3 2025-11-26 09:12:47 ~27 min tests 📄log

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.80%. Comparing base (2e9f21e) to head (290ddf0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7148      +/-   ##
===========================================
- Coverage    59.96%   59.80%   -0.16%     
===========================================
  Files          809      809              
  Lines       113228   113228              
===========================================
- Hits         67892    67713     -179     
- Misses       38490    38627     +137     
- Partials      6846     6888      +42     
Flag Coverage Δ
functional 34.93% <ø> (-0.95%) ⬇️
unit 55.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 44 files with indirect coverage changes

@Ivansete-status Ivansete-status changed the title refactor: complete nwaku integration refactor: complete nwaku integration (timesource) Nov 26, 2025
@Ivansete-status Ivansete-status marked this pull request as ready for review November 26, 2025 09:02
@Ivansete-status Ivansete-status requested a review from a team as a code owner November 26, 2025 09:02
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please point to the changes in waku-go-bindings?

I see that you're moving NTP timesource there. But what effectively change in status-go? We just use an interface defined in a different place? Why is waku/timesource/ntp.go is needed in waku-go-bindings then?

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm overthinking this though. Not blocking.

@Ivansete-status
Copy link
Contributor Author

@igor-sirotin - the change was simply move code from go-waku to waku-go-bindings

@igor-sirotin
Copy link
Collaborator

the change was simply move code from go-waku to waku-go-bindings

Yes, but from all the code you have moved, you only use the Timesource interface, or am I wrong?
Then what's the purpose of having that code in the bindings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants