Skip to content

Conversation

fbarbu15
Copy link
Contributor

@fbarbu15 fbarbu15 commented Oct 7, 2025

Reported #6985

New methods covered:

  • createCommunityChat
  • editCommunityChat
  • deleteCommunityChat
  • reorderCommunityChat
  • shareCommunityChannelURLWithChatKey
  • shareCommunityURLWithChatKey
  • parseSharedURL
  • muteCommunityChats
  • unMuteCommunityChats

@status-im-auto
Copy link
Member

status-im-auto commented Oct 7, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d608d3c #1 2025-10-07 15:13:34 ~3 min linux/status-go 📦zip
✔️ d608d3c #1 2025-10-07 15:13:38 ~3 min macos/status-go 📦zip
✔️ d608d3c #1 2025-10-07 15:17:43 ~7 min windows/status-go 📦zip
✔️ d608d3c #1 2025-10-07 15:20:45 ~10 min linux/nwaku 📦zip
✔️ d608d3c #1 2025-10-07 15:21:34 ~11 min tests-rpc 📄log
✔️ d608d3c #1 2025-10-07 15:37:35 ~27 min tests 📄log
✔️ 7ed2c85 #2 2025-10-10 12:30:00 ~3 min linux/status-go 📦zip
✔️ 7ed2c85 #2 2025-10-10 12:32:07 ~5 min macos/status-go 📦zip
✔️ 7ed2c85 #2 2025-10-10 12:34:12 ~7 min windows/status-go 📦zip
✔️ 7ed2c85 #2 2025-10-10 12:36:57 ~10 min linux/nwaku 📦zip
✔️ 7ed2c85 #2 2025-10-10 12:38:00 ~11 min tests-rpc 📄log
✔️ 7ed2c85 #2 2025-10-10 12:54:09 ~27 min tests 📄log

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.42%. Comparing base (c3bd89f) to head (7ed2c85).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6987      +/-   ##
===========================================
+ Coverage    55.13%   59.42%   +4.28%     
===========================================
  Files          820      821       +1     
  Lines       116624   116626       +2     
===========================================
+ Hits         64301    69303    +5002     
+ Misses       45535    40223    -5312     
- Partials      6788     7100     +312     
Flag Coverage Δ
functional 34.34% <ø> (?)
unit 55.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 216 files with indirect coverage changes

@fbarbu15 fbarbu15 marked this pull request as ready for review October 8, 2025 06:22
Comment on lines 11 to 19
class MutedType(Enum):
MuteFor15Min = 1
MuteFor1Hr = 2
MuteFor8Hr = 3
MuteFor1Week = 4
MuteTillUnmuted = 5
MuteTill1Min = 6
Unmuted = 7
MuteFor24Hr = 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already exists

class MuteType(Enum):
MUTE_FOR15_MIN = 1
MUTE_FOR1_HR = 2
MUTE_FOR8_HR = 3
MUTE_FOR1_WEEK = 4
MUTE_TILL_UNMUTED = 5
MUTE_TILL1_MIN = 6
UNMUTED = 7
MUTE_FOR24_HR = 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did I missed this...
thanks, reusing

"permissions": {"access": 1},
}

def test_create_edit_delete_community_chat(self):
Copy link
Contributor

@rlve rlve Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test could be split into 3 separate tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, devs seem to prefer this type of e2e scenario, that's why I started to do them this way

@fbarbu15 fbarbu15 merged commit 49b18eb into develop Oct 10, 2025
21 checks passed
@fbarbu15 fbarbu15 deleted the test/community-chats branch October 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants