-
Notifications
You must be signed in to change notification settings - Fork 262
test: community chats #6987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: community chats #6987
Conversation
Jenkins Builds
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6987 +/- ##
===========================================
+ Coverage 55.13% 59.42% +4.28%
===========================================
Files 820 821 +1
Lines 116624 116626 +2
===========================================
+ Hits 64301 69303 +5002
+ Misses 45535 40223 -5312
- Partials 6788 7100 +312
Flags with carried forward coverage won't be shown. Click here to find out more. |
class MutedType(Enum): | ||
MuteFor15Min = 1 | ||
MuteFor1Hr = 2 | ||
MuteFor8Hr = 3 | ||
MuteFor1Week = 4 | ||
MuteTillUnmuted = 5 | ||
MuteTill1Min = 6 | ||
Unmuted = 7 | ||
MuteFor24Hr = 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already exists
status-go/tests-functional/resources/enums.py
Lines 36 to 44 in daef497
class MuteType(Enum): | |
MUTE_FOR15_MIN = 1 | |
MUTE_FOR1_HR = 2 | |
MUTE_FOR8_HR = 3 | |
MUTE_FOR1_WEEK = 4 | |
MUTE_TILL_UNMUTED = 5 | |
MUTE_TILL1_MIN = 6 | |
UNMUTED = 7 | |
MUTE_FOR24_HR = 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did I missed this...
thanks, reusing
"permissions": {"access": 1}, | ||
} | ||
|
||
def test_create_edit_delete_community_chat(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test could be split into 3 separate tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, devs seem to prefer this type of e2e scenario, that's why I started to do them this way
Reported #6985
New methods covered: