test: light client discovery #6943
Draft
+117
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (28)
|
Collaborator
Author
|
This test should work when this is resolved: |
igor-sirotin
force-pushed
the
test/light-client-discovery
branch
from
df48dbf to
6c2cec5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6943 +/- ##
============================================
+ Coverage 36.28% 59.76% +23.48%
============================================
Files 800 815 +15
Lines 111467 113558 +2091
============================================
+ Hits 40446 67872 +27426
+ Misses 65933 38853 -27080
- Partials 5088 6833 +1745
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
force-pushed
the
test/light-client-discovery
branch
from
6c2cec5 to
e0ba505
Compare
igor-sirotin
force-pushed
the
test/light-client-discovery
branch
from
e0ba505 to
99d8e61
Compare
Collaborator
Author
|
On CI, test is failing because it discovers MORE peers than required: These are probably the peers from parallel runs, and this is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Blocked until resolved:
The test passes in a fresh setup:
docker compose ...pytest -k test_discoveryBut trying to run the
test_discoveryafter any other tests fails. The problm is that docker reuses IP addresses, and peer exchange server cache seem to only clear it in 10 min. So intest_discoverythe peer exchange client gets a list of nodes from previous test runs. We even try to connect to them, but obviously fail.