Skip to content

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Sep 24, 2021

This issue is very hard to fix without using some profilers. I've been trying with nim profiler and valgrind and actually not that much useful info there. Actually nim profiler gets stuck when app comes to remote procedure call, and just start hanging, so output file is always empty. Using valgrind is slightly better, but it always end up showing to a calls from macOS dyld lib. I managed to see there a lot of calls to ImageLoader::recursiveBind from ImageLoader::recursiveBindWithAccounting (macos dyld class) and started to check how we are loading images in the app and applied some changes here.

If this fix does not solve the issue #3626, it will at least slightly improve performances.

@status-im-auto
Copy link
Member

status-im-auto commented Sep 24, 2021

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fbe5c8d #1 2021-09-24 10:32:47 ~11 min macos 📦dmg
✔️ fbe5c8d #1 2021-09-24 10:37:11 ~15 min linux 📦tgz
✔️ fbe5c8d #1 2021-09-24 10:56:59 ~35 min windows 📦exe

@0x-r4bbit
Copy link
Member

Another thing I've noticed is that the usage of DelegateModel in StatusQ to make Drag and Drop visually work causes the rendering to occasionally freeze.

This will get better once #3676 has landed as it removes DelegateModel again, resulting in a snappier front-end.

@anastasiyaig
Copy link
Contributor

i removed the linked issue #3626 just to keep it opened since this PR is slow to me as well with my data folder, but at the same time it improves our code and does not make any harm so i suggest we merge it and i continue looking into #3626

@iurimatias iurimatias merged commit faaaa24 into master Sep 24, 2021
@iurimatias iurimatias deleted the fix/issue-3626 branch September 24, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants