-
Notifications
You must be signed in to change notification settings - Fork 88
Feat/biometric support android #18949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f19318 to
0fafddf
Compare
Jenkins BuildsClick to see older builds (13)
|
0fafddf to
38c2be2
Compare
Uses Biometric Manager with CryptoObject to make it secure and robust
38c2be2 to
e6b75f1
Compare
alexjba
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as I can read java/jni
Tested on Android and it works nicely
mobile/android/qt6/src/im/status/tablet/SecureAndroidAuthentication.java
Show resolved
Hide resolved
micieslak
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That's great that it fits into existing interface :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Implements Biometric login for Android.
Affected areas
Login flow on android
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
1.mov
2.mov
Impact on end user
How to test
Risk