Skip to content

Conversation

@Khushboo-dev-cpp
Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp commented Oct 2, 2025

What does the PR do

Implements Biometric login for Android.

Affected areas

Login flow on android

Architecture compliance

Screencapture of the functionality

1.mov
2.mov

Impact on end user

How to test

Risk

@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/biometricSupportAndroid branch from 6f19318 to 0fafddf Compare October 2, 2025 15:17
@status-im-auto
Copy link
Member

status-im-auto commented Oct 2, 2025

Jenkins Builds

Click to see older builds (13)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0fafddf #2 2025-10-02 15:27:32 ~10 min ios/aarch64 📦pkg
✔️ 0fafddf #2 2025-10-02 15:27:51 ~10 min android/arm64 🤖apk 📲
✔️ 0fafddf #2 2025-10-02 15:31:03 ~13 min tests/nim 📄log
✔️ 0fafddf #2 2025-10-02 15:33:49 ~16 min macos/aarch64 🍎dmg
✔️ 0fafddf #2 2025-10-02 15:35:27 ~17 min macos/aarch64-nwaku 🍎dmg
✔️ 0fafddf #2 2025-10-02 15:36:10 ~18 min linux/x86_64 📦tgz
✔️ 0fafddf #2 2025-10-02 15:38:49 ~21 min tests/ui 📄log
✔️ 0fafddf #2 2025-10-02 15:42:08 ~24 min linux/x86_64-nwaku 📦tgz
✔️ 0fafddf #2 2025-10-02 15:44:48 ~27 min windows/x86_64 💿exe
✔️ 0fafddf pr18949 2025-10-02 15:54:16 ~18 min tests/e2e 📊rpt
✔️ 0fafddf #3 2025-10-03 14:17:36 ~16 min linux/x86_64 📦tgz
✔️ 0fafddf pr18949 2025-10-03 14:53:05 ~35 min tests/e2e 📊rpt
✔️ 61dfe115 #3 2025-10-03 17:26:58 ~11 min android/arm64 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e6b75f1 #4 2025-10-03 21:33:40 ~7 min tests/nim 📄log
✔️ e6b75f1 #5 2025-10-03 21:35:16 ~9 min android/arm64 🤖apk 📲
✔️ e6b75f1 #4 2025-10-03 21:35:47 ~9 min ios/aarch64 📦pkg
✔️ e6b75f1 #4 2025-10-03 21:39:43 ~13 min tests/ui 📄log
✔️ e6b75f1 #5 2025-10-03 21:42:33 ~16 min linux/x86_64 📦tgz
✔️ e6b75f1 #4 2025-10-03 21:48:15 ~22 min linux/x86_64-nwaku 📦tgz
✔️ e6b75f1 #4 2025-10-03 21:48:26 ~22 min windows/x86_64 💿exe
✔️ e6b75f1 pr18949 2025-10-03 21:59:39 ~17 min tests/e2e 📊rpt
✔️ e6b75f1 #5 2025-10-06 08:55:27 ~11 min macos/aarch64 🍎dmg
✔️ e6b75f1 #6 2025-10-06 09:02:22 ~18 min macos/aarch64-nwaku 🍎dmg
✔️ 3be2b929 #7 2025-10-07 14:01:20 ~6 min android/arm64 🤖apk 📲

@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/biometricSupportAndroid branch from 0fafddf to 38c2be2 Compare October 3, 2025 21:24
Uses Biometric Manager with CryptoObject to make it secure and robust
@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/biometricSupportAndroid branch from 38c2be2 to e6b75f1 Compare October 3, 2025 21:25
@Khushboo-dev-cpp Khushboo-dev-cpp marked this pull request as ready for review October 3, 2025 21:51
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can read java/jni

Tested on Android and it works nicely

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's great that it fits into existing interface :)

@Khushboo-dev-cpp Khushboo-dev-cpp merged commit 3e18c91 into master Oct 7, 2025
13 checks passed
@Khushboo-dev-cpp Khushboo-dev-cpp deleted the feat/biometricSupportAndroid branch October 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants