Envelope processing #7748
Draft
Envelope processing #7748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Dec 1, 2025
beacon_chain/spec/helpers_el.nim
Outdated
| const consensusFork = typeof(blck).kind | ||
| static: doAssert consensusFork >= ConsensusFork.Deneb | ||
|
|
||
| template forkyTransactions: untyped = |
Contributor
There was a problem hiding this comment.
Typically when Nimbus uses forkyFoo, it means the actual Foo (Transaction, say) are different. It seems like in this case the transactions themselves are the same, just housed differently?
tersec
reviewed
Dec 1, 2025
| else: | ||
| blck.body.execution_payload.transactions | ||
| template forkyCommitments: untyped = | ||
| when consensusFork >= ConsensusFork.Gloas: |
Contributor
There was a problem hiding this comment.
Similar point here -- are the commitments any different, or just in a different part of the block/envelope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.