Remove SSZ Union usage in BlockHeaderWithProof type #3019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposal spec change here: ethereum/portal-network-specs#362 |
kdeme
force-pushed
the
remove-union-in-blockheaderwithproof
branch
from
e14513d to
242b9e0
Compare
|
Tests rely on ethereum/portal-spec-tests#34 |
kdeme
force-pushed
the
remove-union-in-blockheaderwithproof
branch
4 times, most recently
from
7cfa38f to
ae7e355
Compare
Remove SSZ Union in BlockHeaderWithProof type by making the proof an SSZ encoded ByteList. The right type for the proof can be selected at the decoding step by first looking into the header for the timestamp and selecting the right type based on the hardfork the block is in.
kdeme
force-pushed
the
remove-union-in-blockheaderwithproof
branch
from
ae7e355 to
097e11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove SSZ Union in BlockHeaderWithProof type by making the proof an SSZ encoded ByteList. The right type for the proof can be selected at the decoding step by first looking into the header for the timestamp and selecting the right type based on the hardfork the block is in.
Draft as this is for a proposal to spec change.