Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key eth_syncing off correct indication, not peer count #2619

Merged
merged 1 commit into from
Sep 12, 2024
Merged

key eth_syncing off correct indication, not peer count #2619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions nimbus/rpc/p2p.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,15 @@ proc setupEthRpc*(

server.rpc("eth_syncing") do() -> SyncingStatus:
## Returns SyncObject or false when not syncing.
# TODO: make sure we are not syncing
# when we reach the recent block
let numPeers = node.peerPool.connectedNodes.len
if numPeers > 0:
var sync = SyncObject(
if com.syncState != Waiting:
let sync = SyncObject(
startingBlock: w3Qty com.syncStart,
currentBlock : w3Qty com.syncCurrent,
highestBlock : w3Qty com.syncHighest
)
result = SyncingStatus(syncing: true, syncObject: sync)
return SyncingStatus(syncing: true, syncObject: sync)
else:
result = SyncingStatus(syncing: false)
return SyncingStatus(syncing: false)

server.rpc("eth_coinbase") do() -> Web3Address:
## Returns the current coinbase address.
Expand Down
Loading