[6.x] Fix Command Palette recents not updating when navigating#13908
Merged
jasonvarga merged 2 commits into6.xfrom Feb 13, 2026
Merged
[6.x] Fix Command Palette recents not updating when navigating#13908jasonvarga merged 2 commits into6.xfrom
jasonvarga merged 2 commits into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the recents state wasn't being updated when navigating in the Command Palette.
It looks like this was caused by a race condition introduced in #13569, where the Command Palette closed before it could call
addToRecentItems. This PR effectively reverts that PR, and fixes the issue in a different way.The "Save", "Edit Blueprint" actions aren't returned by
findSelectedItem()which causes an error in theselect()function when it tries to add to recent, etc.The error means the
reset()function isn't called, which is usually responsible for closing the Command Palette. This PR fixes it by adding a conditional inselect()to avoid the error.Fixes #13904