Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scene list to not use ItemList component #5767

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

WithoutPants
Copy link
Collaborator

Replaces #5745
Related to sidebar work (#5714)

Refactors the SceneList (renaming to FilteredSceneList) to not use the ItemList component. The eventual aim is to remove the ItemList usage from all list components. For now, this will enable me to work on sidebar changes on the scene page in isolation.

  • adds useShowEditFilter utility hook to show the edit filter dialog using the provided modal
  • changes FilteredListToolbar to not use contexts
  • adds utility hook: useFilteredItemList which consolidates the state and usual behaviour for filtered item lists as performed by ItemList
  • adds utility hook: useEmptyFilter which provides an empty filter
  • adds utility hook: useFilterState which handles the filter state while also dealing with URL setting
  • adds utility hook: useFilterOperations which provides a number of functions to alter the filter state
  • adds utility hook: useCloseEditDelete which handles unselecting and refetching when the edit or delete dialog is closed
  • added more fields to useListSelect

@WithoutPants WithoutPants added the chore Pull requests for refactoring and admin work label Mar 25, 2025
@WithoutPants WithoutPants added this to the Version 0.29.0 milestone Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for refactoring and admin work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant