apollo_consensus_orchestrator: Replace skip_write_height config with checking

[guyf-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guyf-starkware]

• apollo_consensus_orchestrator: Replace skip_write_height config with checking #10413 👈 (View in Graphite)
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 6 of 7 files at r1, 1 of 1 files at r2, 1 of 2 files at r3, 1 of 1 files at r4.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @guyf-starkware)

---

crates/apollo_consensus_orchestrator/src/cende/mod.rs line 177 at r2 (raw file):

            // TODO(guy.f): Pass through the current block's commitment and compare it to the latest
            // blob's commitment.
            if latest_blob_height >= height {

I'm not sure but if you are trying to get the previous blob, shouldn't you have -1 here?

Ok, I see that you actually use the prev_height when calling this function. Maybe rename height->prev_height? That would also make it clearer why the logs are discussing previous height.