blockifier: share the test utl assert_eq_test_result #10403
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
+reviewer:@TzahiTaub |
ArniStarkware
left a comment
ArniStarkware
left a comment
There was a problem hiding this comment.
Motivation - We want to have a test similar to the test_get_compiled_class test, but in the blockifier crate, which is independent of the implementation of FetchCompiledClasses.
See: #10392 which will be restack on top of this PR.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @avivg-starkware and @TzahiTaub)
ArniStarkware
force-pushed
the
arni/blockifier/state_api_test_utils/assert_eq_state_result
branch
from
03f1d05 to
bdfbad4
Compare
ArniStarkware
changed the base branch from
main-v0.14.1
to
graphite-base/10403
ArniStarkware
force-pushed
the
arni/blockifier/state_api_test_utils/assert_eq_state_result
branch
from
bdfbad4 to
288fb94
Compare
ArniStarkware
changed the base branch from
graphite-base/10403
to
arni/gateway/rename_test_util_to_sync_state_reader_and
ArniStarkware
force-pushed
the
arni/blockifier/state_api_test_utils/assert_eq_state_result
branch
from
288fb94 to
60cda6e
Compare
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)
crates/apollo_gateway/src/state_reader_test.rs line 447 at r2 (raw file):
// TODO(Arni): Check if any test cases here should move to the tests of // `StateReaderAndContractManager`.
Making sure this is intentionally removed?
Code quote:
// TODO(Arni): Check if any test cases here should move to the tests of
// `StateReaderAndContractManager`.
ArniStarkware
changed the base branch from
arni/gateway/rename_test_util_to_sync_state_reader_and
to
graphite-base/10403
ArniStarkware
force-pushed
the
arni/blockifier/state_api_test_utils/assert_eq_state_result
branch
from
60cda6e to
f4631f0
Compare
ArniStarkware
force-pushed
the
graphite-base/10403
branch
from
27a652b to
0c5c7c2
Compare
ArniStarkware
changed the base branch from
graphite-base/10403
to
main-v0.14.1
ArniStarkware
force-pushed
the
arni/blockifier/state_api_test_utils/assert_eq_state_result
branch
from
f4631f0 to
4b8faf1
Compare
ArniStarkware
left a comment
ArniStarkware
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @avivg-starkware and @TzahiTaub)
crates/apollo_gateway/src/state_reader_test.rs line 447 at r2 (raw file):
Previously, avivg-starkware wrote…
Making sure this is intentionally removed?
It was not! TY! Reverted.
Done.
ArniStarkware
left a comment
ArniStarkware
left a comment
There was a problem hiding this comment.
@ArniStarkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware and @TzahiTaub)
TzahiTaub
left a comment
TzahiTaub
left a comment
There was a problem hiding this comment.
@TzahiTaub reviewed 3 of 4 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware reviewed 1 of 1 files at r3.
Reviewable status:
No description provided.