feat: full speck version implementation #1384
Open
+515
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penovicp
approved these changes
Apr 27, 2025
| } | ||
|
|
||
| throw new LibraryError('Unable to detect specification version'); | ||
| throw new LibraryError( | ||
| `Provided RPC node specification versions ${spec} is not compatible with the SDK. SDK supported RPC versions ${Object.keys(SupportedRpcVersion).toString()}` |
There was a problem hiding this comment.
Suggested change
| `Provided RPC node specification versions ${spec} is not compatible with the SDK. SDK supported RPC versions ${Object.keys(SupportedRpcVersion).toString()}` | |
| `Provided RPC node specification version ${spec} is not compatible with the SDK. SDK supported RPC versions: ${Object.keys(SupportedRpcVersion).toString()}` |
| readonly id = 'RPC071'; | ||
|
|
||
| /** | ||
| * This Channel provide communication using spec version |
There was a problem hiding this comment.
Suggested change
| * This Channel provide communication using spec version | |
| * RPC specification version this Channel class implements |
This is a suggestion to sync the typedoc note with this.specVersion.
| @@ -60,6 +66,9 @@ export class RpcChannel { | |||
|
|
|||
| private chainId?: StarknetChainId; | |||
|
|
|||
| /** | |||
| * Connected RPC node specification version | |||
There was a problem hiding this comment.
Suggested change
| * Connected RPC node specification version | |
| * RPC specification version of the connected node |
This is a suggestion to sync the typedoc note with this. channelSpecVersion .
| */ | ||
| public getSpecificationVersion() { | ||
| return this.fetchEndpoint('starknet_specVersion'); | ||
| public async setupSpecVersion() { |
There was a problem hiding this comment.
Nitpick, setup is usually used as a noun and set up as the corresponding verb form so the method would be setUpSpecVersion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Expand subversion specification validation on provider instantiation with create().
SupportedRpcVersionis now the full spec version 0.8.1[provider, channel].readSpecVersion()read recorded spec version from channel[provider, channel].getSpecVersion()fetch from API full spec version[provider, channel].setupSpecVersion()has functionality of oldgetSpecVersion(), return spec version if recorded else fetch, test for supported versions and store if fine, else throw errorRpcChannel.channelSpecVersionconstant specifying for which specversion the channel is designedUsage related changes
Moved version and resolution util methods from
utils/providertoutils/resolveDevelopment related changes
Spec version is now in full form major.minor.patch (actual starknet spec is major.major.major)
Checklist: