Skip to content

fix: add Lava RPC node to default Free RPC Nodes #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gap-editor
Copy link

REOPENING #1335

Motivation and Resolution

This PR adds Lava RPC node (https://www.lavanet.xyz/) as one of the default RPC providers for both Mainnet and Sepolia networks. This addition increases the reliability and availability of RPC nodes for StarkNet.js users by providing an additional fallback option.

Resolves #1331

RPC version (if applicable)

Using default RPC version (v0_7) consistent with other providers

Usage related changes

  • Added Lava RPC node (https://starknet.lava.build/rpc/v0_7) to the default RPC nodes list for both SN_MAIN and SN_SEPOLIA networks
  • Users will automatically get access to Lava RPC node when using default provider configuration
  • No breaking changes - existing code will continue to work as before

Development related changes

  • Updated constants.ts to include new RPC endpoint
  • No changes to testing infrastructure required as existing provider tests will automatically cover the new endpoint

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch
  • Linked the issues which this PR resolves (Add Lava RPC node to default Free RPC Nodes #1331)
  • Documented the changes in code
  • No test updates needed as existing tests cover provider functionality
  • All tests are passing

Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense to merge since the provided URLs seem to point to load balancers that don't take the version path fragment into account, this means that requests made to them are randomly sent to either a 0.7 or 0.8 node.

@gap-editor gap-editor requested a review from penovicp April 17, 2025 16:46
@PhilippeR26
Copy link
Collaborator

Even when adding rpc version in url, the rpc version remains random:
image
Tested also with

   "https://rpc.starknet-testnet.lava.build/rpc/v0_8",
    "https://rpc.starknet-testnet.lava.build/0_8",
    "https://rpc.starknet-testnet.lava.build/0.8",
    "https://rpc.starknet.lava.build/rpc/v0_8",
    "https://rpc.starknet.lava.build/0_8",
    "https://rpc.starknet.lava.build/0.8",

Results:

{ results: [ '0.7', '0.7', '0.7', '0.8', '0.7', '0.7' ] }
{ results: [ '0.7', '0.7', '0.7', '0.7', '0.8', '0.7' ] }
{ results: [ '0.7', '0.7', '0.8', '0.7', '0.7', '0.7' ] }
{ results: [ '0.7', '0.7', '0.7', '0.8', '0.8', '0.7' ] }
{ results: [ '0.7', '0.7', '0.7', '0.8', '0.7', '0.8' ] }
{ results: [ '0.7', '0.7', '0.8', '0.8', '0.8', '0.8' ] }
{ results: [ '0.7', '0.7', '0.7', '0.7', '0.8', '0.7' ] }
{ results: [ '0.7', '0.7', '0.7', '0.8', '0.8', '0.8' ] }
{ results: [ '0.7', '0.7', '0.8', '0.7', '0.8', '0.7' ] }
{ results: [ '0.7', '0.7', '0.8', '0.8', '0.7', '0.8' ] }

@tabaktoni
Copy link
Member

Issue on hold
#1331

@tabaktoni tabaktoni closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lava RPC node to default Free RPC Nodes
4 participants