Skip to content

fix: ensure enum replacement objects are reachable for type resolution #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

penovicp
Copy link
Collaborator

@penovicp penovicp commented Apr 8, 2025

Motivation and Resolution

Completes the transition from TS enums into their companion pattern replacements. Also repairs the reachability of the SupportedRpcVersion object that was being hidden by the type in the distribution build.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@PhilippeR26
Copy link
Collaborator

The SupportedRpcVersion properties are difficult to reach :
SupportedRpcVersion.0.7 is not valid, due to the point in the property name.
Maybe to replace by 0_7 and 0_8...

@PhilippeR26 PhilippeR26 requested review from tabaktoni and removed request for tabaktoni April 8, 2025 13:42
@penovicp penovicp marked this pull request as ready for review April 10, 2025 06:03
@penovicp
Copy link
Collaborator Author

The SupportedRpcVersion properties are difficult to reach : SupportedRpcVersion.0.7 is not valid, due to the point in the property name. Maybe to replace by 0_7 and 0_8...

For dot notation to work the key would need to start with a letter, underscore, or dollar sign, so I went with v07.

Copy link
Collaborator

@PhilippeR26 PhilippeR26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have both in vscode, but it's OK.
image

@penovicp penovicp merged commit eb8b10d into develop Apr 10, 2025
@penovicp penovicp deleted the fix/ts-enum branch April 10, 2025 08:47
github-actions bot pushed a commit that referenced this pull request Apr 14, 2025
# [7.1.0](v7.0.1...v7.1.0) (2025-04-14)

### Bug Fixes

* ensure enum replacement objects are reachable for type resolution ([#1375](#1375)) ([eb8b10d](eb8b10d))
* make the provider create method generic to enable it when mixins are applied ([#1370](#1370)) ([1f48dc6](1f48dc6))

### Features

* update to rpc 0.8.1 ([83e17b8](83e17b8))
Copy link

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants